Skip to content

Handle 400 error in user creation check #4805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2024
Merged

Handle 400 error in user creation check #4805

merged 1 commit into from
Sep 25, 2024

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Sep 25, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR updates the error handling in the auth-actions.ts file to accommodate additional error codes during user creation. It broadens the condition to check for both 404 and 400 status codes.

Detailed summary

  • Modified the error handling condition to check for both 404 and 400 status codes when a user is not found.
  • Added a TODO comment explaining the reasoning behind checking for the additional 400 status code due to secretKey authentication.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2024 8:21pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 25, 2024 8:21pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 25, 2024 8:21pm
wallet-ui ⬜️ Skipped (Inspect) Sep 25, 2024 8:21pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 20:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 20:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 20:08 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 39aeb14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jnsdls jnsdls marked this pull request as ready for review September 25, 2024 20:08
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 25, 2024
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

@codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.12%. Comparing base (8e9d13c) to head (39aeb14).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4805   +/-   ##
=======================================
  Coverage   49.12%   49.12%           
=======================================
  Files        1051     1051           
  Lines       56679    56679           
  Branches     3892     3892           
=======================================
  Hits        27846    27846           
  Misses      28200    28200           
  Partials      633      633
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8e9d13c
packages 45.19% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 540 ms (+124.84% 🔺) 1.4 s
thirdweb (cjs) 101.56 KB (0%) 2.1 s (0%) 657 ms (+14.07% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 52 ms (+14.46% 🔺) 148 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 42 ms (+183.73% 🔺) 52 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 63 ms (+4.5% 🔺) 398 ms

@jnsdls jnsdls added the hotfix This pull request should be prioritized in the merge queue. label Sep 25, 2024 — with Graphite App
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 25, 2024 •
edited
Loading

Merge activity

@jnsdls jnsdls force-pushed the Handle_400_error_in_user_creation_check branch from 21991bc to 39aeb14 Compare September 25, 2024 20:18
@vercel vercel bot temporarily deployed to Preview – docs-v2 September 25, 2024 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 25, 2024 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui September 25, 2024 20:18 Inactive
@graphite-app graphite-app bot merged commit 39aeb14 into main Sep 25, 2024
@graphite-app graphite-app bot deleted the Handle_400_error_in_user_creation_check branch September 25, 2024 20:21
@vercel vercel bot temporarily deployed to Production – wallet-ui September 25, 2024 20:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground September 25, 2024 20:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 September 25, 2024 20:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @MananTank